Skip to content

Fix vignette install/file-write/filter issues from issue #46 - #51

Open
RonaldRonnie wants to merge 1 commit into
waldronlab:mainfrom
RonaldRonnie:fix/vignette-audit-issue-46
Open

Fix vignette install/file-write/filter issues from issue #46#51
RonaldRonnie wants to merge 1 commit into
waldronlab:mainfrom
RonaldRonnie:fix/vignette-audit-issue-46

Conversation

@RonaldRonnie

@RonaldRonnie RonaldRonnie commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

this PR introduces fixes to the open issue #46 and for not gate stray install.packages() calls behind eval=FALSE, redirect hardcoded file outputs (xlsx/png) to tempdir(), and simplify which()-wrapped OR-chain filters to %in% across three vignettes.
All filter rewrites verified byte-identical via synthetic-data
equivalence tests.

Closes : #46

@RonaldRonnie
RonaldRonnie force-pushed the fix/vignette-audit-issue-46 branch from 079a045 to f311bc2 Compare August 19, 2026 11:06
@RonaldRonnie
RonaldRonnie force-pushed the fix/vignette-audit-issue-46 branch from f311bc2 to 15eda7a Compare August 19, 2026 11:12
@RonaldRonnie

Copy link
Copy Markdown
Contributor Author

@cmirzayi and @fiddyhamma
I have this PR up that you could test and and may be if am not repeating what Peace is currently working on regarding #46

@RonaldRonnie
RonaldRonnie requested a review from cmirzayi August 19, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Further refinements of existing vignettes

1 participant