GENEActiv non-linear light calibration - #99
Merged
Merged
Conversation
vincentvanhees
requested changes
Sep 14, 2026
Member
There was a problem hiding this comment.
Thanks Ying!
Could you please clarify in the documentation .Rd file:
- That this correction has been provided by you as ActivInsights Ltd. This to reassure user that it is trustworthy.
- Explanation of where users can find additional information on the need for this correction?
- Spell out in which GENEActiv versions this correction will or will not be applied. I know it is implicitly in the code, but I think it would help users understand whether their data is affected.
- Describe briefly in words the nature of the calibration, e.g. "In models higher than 1.1 the code uses light range specific offset corrections".... or something similar.
| @@ -1,3 +1,7 @@ | |||
| # Changes in version 1.0.11 (release date:07-09-2026) | |||
|
|
|||
| - Updated GENEActiv light calibration to account for differences between device models. | |||
Member
There was a problem hiding this comment.
Can we rephrase this to "Added GENEActiv light calibration needed for newer device models. (contributed by ActivInsights Ltd manufacturer of odel provided by GENEActiv manufacturer)."
to reassure user that there was nothing wrong with the old devices and to clarify that you contributed this.
Contributor
Author
There was a problem hiding this comment.
I have rephrased this slightly, making clear that the light calibration is based on device model and that ActivInsights has contributed to this update.
vincentvanhees
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply non-linear calibration to raw light data from non-1.1 devices.