Specify audio decoder priming sample discard and timestamp adjustment - #948
Merged
Merged
Conversation
dalecurtis
force-pushed
the
ts_discard
branch
2 times, most recently
from
September 3, 2026 23:35
58e3a3f to
e3f2c04
Compare
padenot
reviewed
Sep 18, 2026
padenot
approved these changes
Sep 18, 2026
padenot
left a comment
padenot
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, thanks a lot. As said in the other PR, this will need a follow-up, that I'll likely do.
…#944) Audio decoders now automatically discard priming samples if present in the bitstream or configuration description. Decoded outputs have their initial timestamps adjusted forward by the duration of discarded priming samples. - Add [[priming samples to discard]] slot to AudioDecoder. - In configure(), initialize slot from description if specified. - In decode(), update slot from chunk data if specified. - In Output AudioData, discard priming samples up to slot value, decrement slot, discard completely dropped outputs, and adjust surviving output's timestamp forward by discarded duration rounded to microseconds. Fixes #944 See #626 TAG=agy CONV=fb1a957f-7551-4aa1-b394-2244fb156d73
dalecurtis
force-pushed
the
ts_discard
branch
from
September 21, 2026 17:56
e3f2c04 to
ad3b075
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audio decoders now automatically discard priming samples if present in the bitstream or configuration description. Decoded outputs have their initial timestamps adjusted forward by the duration of discarded priming samples.
Due to a bikeshed stacking issue, the codec registry is updated in a secondary PR.
Fixes #944
See #626