docs: fix stale pre-mode claims and review nits from #737 - #747
Merged
Conversation
#737 lazy-loaded release guidance but kept present-tense "repo is in pre mode" after the 1.0.0 cut (#687). Correct that, and land the rest of the review follow-ups: - CLAUDE.md / releasing skill: drop false pre/beta state; reframe as optional pre-channel re-entry; point at skill path explicitly - CLAUDE.md: metrics is CI-only (local: test:bench); keep isThenable in the utilities pointer; note checklist is path-scoped - releasing skill: add changeset / release:prepare commands - new-feature-checklist: match sibling single-line paths frontmatter - apps/docs/CLAUDE.md: gn-example is canonical for feature pages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #737. That PR correctly trimmed always-loaded context and scoped the checklist, but it migrated present-tense pre-mode instructions into the new
releasingskill after the repo had already exited pre mode (#687) and shipped stable1.0.x.Critical
CLAUDE.mdand.claude/skills/releasing/SKILL.mdpre enter→ ship →pre exit), gated on.changeset/pre.jsonexistingImportant
.claude/skills/releasing/SKILL.mdpnpm metricscomment: CI metrics-regen only; local iteration ispnpm test:bench(do not commit artifacts from feature branches)paths:frontmatter matches sibling single-line styleSuggestions
isThenablenamed in the utilities pointerrelease:preparelisted under skill Commandsapps/docs/CLAUDE.md:::: gn-exampleis canonical for feature pages; DocsExample recipe scoped to.vuepagesTest plan
.changeset/pre.jsonon master; skill no longer claims pre mode as currentpaths:globs unchanged, style aligned with other rules