Skip to content

Support casting to Decimal in Primitive CastKernel - #9288

Open
mhk197 wants to merge 6 commits into
developfrom
mk/primitive-to-decimal-cast
Open

Support casting to Decimal in Primitive CastKernel#9288
mhk197 wants to merge 6 commits into
developfrom
mk/primitive-to-decimal-cast

Conversation

@mhk197

@mhk197 mhk197 commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Add casts from integer primitive arrays to decimal arrays.

Signed-off-by: Matt Katz <mhkatz97@gmail.com>
@mhk197 mhk197 added the changelog/feature A new feature label Aug 7, 2026
@codspeed-hq

codspeed-hq Bot commented Aug 7, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 9.54%

⚡ 3 improved benchmarks
❌ 6 regressed benchmarks
✅ 1928 untouched benchmarks
🆕 2 new benchmarks
⏩ 85 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation cast_i32_to_u32[65536] 1.8 ms 2.8 ms -35.45%
Simulation decode_varbin[(1000, 2)] 61.1 µs 78.2 µs -21.95%
Simulation cold_misaligned[(64, 256)] 4.4 ms 5.3 ms -16.96%
Simulation chunked_dict_primitive_into_canonical[f64, (1000, 10, 100)] 2.2 ms 2.5 ms -11.1%
Simulation chunked_dict_primitive_into_canonical[f64, (1000, 100, 100)] 2.4 ms 2.6 ms -10.59%
Simulation chunked_dict_primitive_canonical_into[f64, (1000, 100, 100)] 2.1 ms 2.4 ms -10.19%
Simulation decompress[u64, (1000, 16)] 72.2 µs 64.4 µs +12.08%
Simulation take[small_m/shuffled/primitive/nonnull/chunks=1024/indices=256] 2.4 ms 2.2 ms +10.09%
Simulation take[small_m/shuffled/primitive/nonnull/chunks=1024/indices=1000] 6.5 ms 5.9 ms +10%
🆕 Simulation cast_i64_to_decimal38_scale2[65536] N/A 3.7 ms N/A
🆕 Simulation cast_i32_to_decimal9_scale2[65536] N/A 1.4 ms N/A

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing mk/primitive-to-decimal-cast (ee1f548) with develop (19f771f)

Open in CodSpeed

Footnotes

  1. 85 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

mhk197 added 4 commits August 7, 2026 11:40
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
@mhk197 mhk197 changed the title cast primitive arrays to decimal Support casting to Decimal in Primitive CastKernel Aug 7, 2026
Signed-off-by: Matt Katz <mhkatz97@gmail.com>
@mhk197
mhk197 marked this pull request as ready for review August 7, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant