ci(bench): do not fail benchmarks when Polar Signals setup fails - #9286
Open
joseph-isaacs wants to merge 1 commit into
Open
ci(bench): do not fail benchmarks when Polar Signals setup fails#9286joseph-isaacs wants to merge 1 commit into
joseph-isaacs wants to merge 1 commit into
Conversation
The Parca Agent release download in the Polar Signals setup step is a
network operation that can fail transiently ("socket hang up"), which
currently aborts the whole benchmark job before it runs. Profiling is
supplementary to the benchmark results, and the debuginfo pre-upload step
is already continue-on-error, so let the benchmark proceed without it.
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Merging this PR will degrade performance by 0.11%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The
Setup Polar Signalsstep downloads the Parca Agent release binary over the network, and that download can fail transiently. In run 31181958893 it failed withsocket hang upthree times in a ~28s window (the action's own retries at 18s and 10s), which aborted thecompression-benchjob before the benchmark ran.That failure was a flake, not a config problem: 15 other jobs in the same run executed the identical step — same pinned action, same
parca_agent_version: "0.49.0"— and succeeded, two of them within seconds of the failure.Profiling is supplementary to the benchmark results, so a dropped connection while fetching the agent should not cost us the whole benchmark job. The adjacent
Pre-upload benchmark debuginfo to Polar Signalsstep is alreadycontinue-on-error: true; this makes the setup step consistent with it.What changes are included in this PR?
Adds
continue-on-error: true(with a one-line comment explaining why) to theSetup Polar Signalsstep in the three workflows that run it:.github/workflows/pr-bench-runner.yml.github/workflows/develop-bench.yml.github/workflows/sql-bench-matrix.ymlWhen the step fails, the job now continues into
Setup benchmark environmentand runs the benchmark without profiling data, instead of failing outright. The step is still reported as failed in the job summary, so the flake stays visible.Checks run:
yamllint --strict -c .yamllint.yamlon all three changed workflows. No Rust or other code is touched, so no cargo checks were run.What APIs are changed? Are there any user-facing changes?
None. CI configuration only.
Generated by Claude Code