Skip to content

Share tree display traversal and rendering - #9280

Open
joseph-isaacs wants to merge 2 commits into
developfrom
agent/shared-tree-display
Open

Share tree display traversal and rendering#9280
joseph-isaacs wants to merge 2 commits into
developfrom
agent/shared-tree-display

Conversation

@joseph-isaacs

@joseph-isaacs joseph-isaacs commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add shared tree traversal and indented/branch renderers in vortex-utils
  • migrate array and expression tree displays to the shared implementation
  • preserve existing display output while removing duplicated traversal code

@joseph-isaacs joseph-isaacs added the changelog/skip Do not list PR in the changelog label Aug 7, 2026
@joseph-isaacs
joseph-isaacs marked this pull request as ready for review August 7, 2026 15:34
@joseph-isaacs

Copy link
Copy Markdown
Contributor Author

This can should and will be used in other places too

@joseph-isaacs
joseph-isaacs force-pushed the agent/shared-tree-display branch from c9fcd3a to cf4255f Compare August 7, 2026 15:57
@codspeed-hq

codspeed-hq Bot commented Aug 7, 2026

Copy link
Copy Markdown

Merging this PR will regress 1 benchmark

⚡ 7 improved benchmarks
❌ 1 regressed benchmark
✅ 1929 untouched benchmarks
⏩ 51 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation compress_fsst[(1000, 64, 8)] 1 ms 1.1 ms -10.95%
Simulation compact_sliced[(16384, 10)] 1.9 ms 1.4 ms +36.09%
Simulation compact_sliced[(4096, 10)] 514.7 µs 385.2 µs +33.61%
Simulation chunked_canonicalize_into[(1000, 50, 8, 64)] 17.5 ms 15.6 ms +11.81%
Simulation chunked_canonicalize_into[(1000, 50, 8, 4)] 14.6 ms 13.2 ms +10.73%
Simulation compact[(16384, 10)] 4.9 ms 4.4 ms +10.38%
Simulation compact[(4096, 10)] 1.3 ms 1.1 ms +10.08%
Simulation chunked_into_canonical[(1000, 50, 8, 4)] 16.9 ms 15.3 ms +10.01%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing agent/shared-tree-display (8753468) with develop (adab5b8)2

Open in CodSpeed

Footnotes

  1. 51 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (66c447e) during the generation of this report, so adab5b8 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
@joseph-isaacs
joseph-isaacs force-pushed the agent/shared-tree-display branch from a04662a to 8753468 Compare August 7, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants