feat(vortex-spatial): add collect scalar function - #9218
Open
HarukiMoriarty wants to merge 5 commits into
Open
Conversation
Merging this PR will degrade performance by 45.6%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
HarukiMoriarty
force-pushed
the
nemo/geo-collect
branch
from
August 6, 2026 14:41
cbdcade to
2d42fa0
Compare
HarukiMoriarty
force-pushed
the
nemo/geo-collect
branch
from
August 6, 2026 17:58
2d42fa0 to
9428981
Compare
HarukiMoriarty
force-pushed
the
nemo/geo-collect
branch
from
August 6, 2026 20:13
9428981 to
7468ff5
Compare
HarukiMoriarty
force-pushed
the
nemo/geo-collect
branch
from
August 7, 2026 13:52
40ca780 to
5aa8c2d
Compare
HarukiMoriarty
force-pushed
the
nemo/geo-collect
branch
from
August 7, 2026 14:44
5aa8c2d to
b38399b
Compare
HarukiMoriarty
force-pushed
the
nemo/geo-collect
branch
from
August 7, 2026 18:17
b38399b to
f28206c
Compare
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
HarukiMoriarty
force-pushed
the
nemo/geo-collect
branch
from
August 7, 2026 20:24
f28206c to
91e62f5
Compare
Return `ExtDTypeRef` from `collect_dtype` so `execute` stops unwrapping the extension back out of a `DType` and no longer carries two names for one value, matching how `convex_hull_dtype` resolves its output. Fold the two element-type rejections into one match so the "not a native Point, LineString, or Polygon" message has a single source, and take the output nullability from the `Execution` the dispatcher already populated instead of re-deriving it from the output dtype. Signed-off-by: Nemo Yu <zyu379@wisc.edu>
`ListViewArray::try_new` always reports `is_zero_copy_to_list` as false, so the list view collect handed back forgot that its views are still exact. The next `list_from_list_view` then re-gathered the entire geometry payload that the all-valid path had just reused, moving the copy one operator later instead of avoiding it. Forward the input's flag instead. The reuse path passes `offsets` and `sizes` through untouched, and the compaction path rebuilds them as a running sum over the same element order, so the zero-copy invariant holds on both; `validate_zctl` checks it under debug assertions. `ST_Envelope(ST_Collect(points))` over 512 rows of 8 points improves from 10.54us to 8.42us fastest and 10.72us to 8.54us median. The existing cases cannot observe this because `Canonical`'s list form is itself a `ListViewArray`, so add one that composes collect with a consumer converting to a `ListArray`. Signed-off-by: Nemo Yu <zyu379@wisc.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary