Implement validity for Between scalar function#7519
Open
robert3005 wants to merge 2 commits intodevelopfrom
Open
Implement validity for Between scalar function#7519robert3005 wants to merge 2 commits intodevelopfrom
robert3005 wants to merge 2 commits intodevelopfrom
Conversation
Signed-off-by: Robert Kruszewski <github@robertk.io>
robert3005
added
changelog/fix
github-actions
bot
removed
the
action/benchmark-sql
Contributor
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): 0.921x ➖ datafusion / vortex-file-compressed (0.921x ➖, 3↑ 0↓)
|
Contributor
File Sizes: PolarSignals ProfilingNo file size changes detected. |
Contributor
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.035x ➖, 0↑ 2↓)
datafusion / vortex-compact (0.986x ➖, 0↑ 0↓)
datafusion / parquet (0.996x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.028x ➖, 0↑ 1↓)
duckdb / vortex-compact (0.973x ➖, 1↑ 0↓)
duckdb / parquet (1.022x ➖, 0↑ 1↓)
Full attributed analysis
|
Contributor
File Sizes: FineWeb NVMeNo file size changes detected. |
Contributor
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.973x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.984x ➖, 0↑ 0↓)
datafusion / parquet (0.968x ➖, 2↑ 1↓)
datafusion / arrow (1.006x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed (0.990x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.992x ➖, 0↑ 0↓)
duckdb / parquet (0.954x ➖, 3↑ 0↓)
duckdb / duckdb (0.961x ➖, 2↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-H SF=1 on NVMENo file size changes detected. |
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.781x ✅, 98↑ 0↓)
datafusion / vortex-compact (0.799x ✅, 95↑ 0↓)
datafusion / parquet (0.853x ✅, 83↑ 0↓)
duckdb / vortex-file-compressed (0.868x ✅, 72↑ 0↓)
duckdb / vortex-compact (0.919x ➖, 29↑ 1↓)
duckdb / parquet (0.882x ✅, 56↑ 0↓)
duckdb / duckdb (0.884x ✅, 51↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-DS SF=1 on NVMENo file size changes detected. |
Contributor
Benchmarks: FineWeb S3Verdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.904x ➖, 1↑ 1↓)
datafusion / vortex-compact (0.980x ➖, 1↑ 2↓)
datafusion / parquet (0.964x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.997x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.983x ➖, 0↑ 0↓)
duckdb / parquet (0.954x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) duckdb / vortex-file-compressed (1.032x ➖, 0↑ 1↓)
duckdb / vortex-compact (0.992x ➖, 0↑ 0↓)
duckdb / parquet (0.984x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: Statistical and Population GeneticsNo file size changes detected. |
Contributor
Benchmarks: TPC-H SF=10 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.052x ➖, 0↑ 2↓)
datafusion / vortex-compact (1.094x ➖, 0↑ 4↓)
datafusion / parquet (1.029x ➖, 0↑ 0↓)
datafusion / arrow (1.061x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed (1.036x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.033x ➖, 0↑ 0↓)
duckdb / parquet (1.021x ➖, 0↑ 0↓)
duckdb / duckdb (1.014x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-H SF=10 on NVMENo file size changes detected. |
Contributor
Benchmarks: TPC-H SF=1 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.922x ➖, 2↑ 1↓)
datafusion / vortex-compact (0.872x ➖, 2↑ 0↓)
datafusion / parquet (0.951x ➖, 1↑ 1↓)
duckdb / vortex-file-compressed (0.958x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.027x ➖, 0↑ 0↓)
duckdb / parquet (0.952x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
Benchmarks: TPC-H SF=10 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.924x ➖, 1↑ 1↓)
datafusion / vortex-compact (0.832x ➖, 2↑ 0↓)
datafusion / parquet (0.798x ➖, 6↑ 0↓)
duckdb / vortex-file-compressed (1.074x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.091x ➖, 0↑ 1↓)
duckdb / parquet (1.087x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
Author
|
apparently this was not enough :( |
Merging this PR will improve performance by 23.2%
Performance Changes
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid using IsNotNull(expr) fallback which can lead to infinite recursion. As a followup we should make validity required thing for scalar functions
Signed-off-by: Robert Kruszewski github@robertk.io