Hack to support forcing normalization#7517
Merged
connortsui20 merged 1 commit intodevelopfrom Apr 17, 2026
Merged
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
robert3005
approved these changes
Apr 17, 2026
connortsui20
added
changelog/skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We need to support normalization of vector arrays to perform faster compute. However, this will essentially always create larger arrays on disk. This is a hack specifically for
L2Denormthat will allow us write normalized vector arrays to disk.Given that writing scalar fn arrays to disk is already gated by an environment variable and the unstable encodings feature flag, I think this hack is fine for now.
Testing
This just allows some arrays that are larger than canonical.