add unchecked array slot take and put#7514
Merged
joseph-isaacs merged 6 commits intodevelopfrom Apr 17, 2026
Merged
Conversation
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Merging this PR will degrade performance by 23.8%
Performance Changes
Comparing 
Footnotes
|
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (1)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): 0.979x ➖ datafusion / vortex-file-compressed (0.979x ➖, 0↑ 0↓)
|
Contributor
File Sizes: PolarSignals ProfilingNo file size changes detected. |
Contributor
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.965x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.979x ➖, 0↑ 0↓)
datafusion / parquet (1.000x ➖, 0↑ 1↓)
datafusion / arrow (0.994x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.984x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.987x ➖, 0↑ 0↓)
duckdb / parquet (0.970x ➖, 2↑ 1↓)
duckdb / duckdb (0.957x ➖, 1↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-H SF=1 on NVMENo file size changes detected. |
Contributor
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.232x ❌, 0↑ 8↓)
datafusion / vortex-compact (1.195x ❌, 0↑ 9↓)
datafusion / parquet (1.197x ❌, 0↑ 9↓)
duckdb / vortex-file-compressed (1.223x ❌, 0↑ 7↓)
duckdb / vortex-compact (1.190x ❌, 0↑ 7↓)
duckdb / parquet (1.211x ❌, 0↑ 9↓)
Full attributed analysis
|
Contributor
File Sizes: FineWeb NVMeNo file size changes detected. |
Contributor
Benchmarks: FineWeb S3Verdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.007x ➖, 1↑ 2↓)
datafusion / vortex-compact (1.021x ➖, 1↑ 2↓)
datafusion / parquet (1.091x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.981x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.967x ➖, 0↑ 0↓)
duckdb / parquet (0.985x ➖, 0↑ 0↓)
Full attributed analysis
|
| slot_idx: usize, | ||
| ) -> VortexResult<(ArrayRef, ArrayRef)> { | ||
| let child = if let Some(inner) = Arc::get_mut(&mut self.0) { | ||
| unsafe { inner.slots_mut()[slot_idx].take() } |
Contributor
Benchmarks: TPC-H SF=10 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.981x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.968x ➖, 1↑ 4↓)
datafusion / parquet (0.975x ➖, 1↑ 2↓)
duckdb / vortex-file-compressed (1.044x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.048x ➖, 0↑ 0↓)
duckdb / parquet (1.045x ➖, 0↑ 0↓)
Full attributed analysis
|
connortsui20
approved these changes
Apr 17, 2026
Contributor
connortsui20
left a comment
connortsui20
left a comment
There was a problem hiding this comment.
Clean up the unsafe code and I think this is fine to merge
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.813x ✅, 92↑ 0↓)
datafusion / vortex-compact (0.854x ✅, 73↑ 0↓)
datafusion / parquet (0.863x ✅, 74↑ 0↓)
duckdb / vortex-file-compressed (0.898x ✅, 38↑ 0↓)
duckdb / vortex-compact (0.921x ➖, 30↑ 1↓)
duckdb / parquet (0.932x ➖, 22↑ 0↓)
duckdb / duckdb (0.895x ✅, 45↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-DS SF=1 on NVMENo file size changes detected. |
Contributor
Benchmarks: Random AccessVortex (geomean): 0.866x ✅ unknown / unknown (0.947x ➖, 9↑ 1↓)
|
Contributor
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) duckdb / vortex-file-compressed (1.077x ➖, 0↑ 1↓)
duckdb / vortex-compact (1.034x ➖, 0↑ 0↓)
duckdb / parquet (1.026x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: Statistical and Population GeneticsNo file size changes detected. |
Contributor
Benchmarks: TPC-H SF=10 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.081x ➖, 0↑ 4↓)
datafusion / vortex-compact (1.070x ➖, 0↑ 1↓)
datafusion / parquet (1.066x ➖, 0↑ 1↓)
datafusion / arrow (1.097x ➖, 0↑ 8↓)
duckdb / vortex-file-compressed (1.079x ➖, 0↑ 4↓)
duckdb / vortex-compact (1.062x ➖, 0↑ 0↓)
duckdb / parquet (1.023x ➖, 1↑ 0↓)
duckdb / duckdb (1.027x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-H SF=10 on NVMENo file size changes detected. |
Contributor
Benchmarks: TPC-H SF=1 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.929x ➖, 1↑ 1↓)
datafusion / vortex-compact (0.968x ➖, 0↑ 1↓)
datafusion / parquet (1.049x ➖, 2↑ 2↓)
duckdb / vortex-file-compressed (0.955x ➖, 1↑ 0↓)
duckdb / vortex-compact (0.986x ➖, 0↑ 1↓)
duckdb / parquet (0.957x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
🚨🚨🚨❌❌❌ SQL BENCHMARK FAILED ❌❌❌🚨🚨🚨Benchmark |
Contributor
Benchmarks: CompressionVortex (geomean): 1.007x ➖ unknown / unknown (1.033x ➖, 1↑ 18↓)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds crate-private unchecked slot take/put helpers on
ArrayRef. This allows for in-place swapping of array children is the array is exclusively owned.