Propagate min/max/string length statistics to duckdb#7416
Merged
Conversation
5848867 to
c4a56e6
Compare
c4a56e6 to
69e130d
Compare
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (6)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.771x ✅, 98↑ 0↓)
datafusion / vortex-compact (0.806x ✅, 92↑ 0↓)
datafusion / parquet (0.815x ✅, 97↑ 0↓)
duckdb / vortex-file-compressed (0.878x ✅, 54↑ 3↓)
duckdb / vortex-compact (0.999x ➖, 26↑ 33↓)
duckdb / parquet (0.880x ✅, 55↑ 0↓)
duckdb / duckdb (0.849x ✅, 77↑ 0↓)
Full attributed analysis
|
Contributor
File Sizes: TPC-DS SF=1 on NVMENo file size changes detected. |
ccd30ce to
9fa66ab
Compare
9fa66ab to
1b00b56
Compare
1b00b56 to
01be008
Compare
Signed-off-by: Mikhail Kot <to@myrrc.dev>
Signed-off-by: Mikhail Kot <to@myrrc.dev>
Contributor
|
@claude review in depth for correctness and performance |
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
robert3005
reviewed
Apr 17, 2026
Contributor
robert3005
left a comment
There was a problem hiding this comment.
There's couple of things that can be improved. The general problem we have to solve (not here, right now) is how we get stats out of layouts
robert3005
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate min/max/max_length/nullable stats for single-file reads in duckdb.
Fix a bug in file statistics merge where it assumed sum to be applied only on primitive types.