fix: align byteplus viking kb tos region - #890
Open
xgtcode wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix BytePlus Viking knowledge base TOS region alignment.
When creating or writing to a Viking knowledge base on BytePlus, the Viking region is normalized to
cn-hongkong, but the default TOS config previously stayed on the BytePlus global defaultap-southeast-1. This could make document upload and bucket creation/checking use different TOS regions.This change:
cn-hongkongfor BytePlus Viking knowledge base usage.tos_config,DATABASE_TOS_REGION, orDATABASE_TOS_ENDPOINT.TOSConfig.bucketcreates/checks the bucket withregion=self.region, so bucket setup and later upload use the same TOS region.Tests
uv run pytest tests/test_vikingdb_knowledge_backend.py tests/test_ve_tos.pyuv run pre-commit run --files veadk/configs/database_configs.py veadk/knowledgebase/backends/vikingdb_knowledge_backend.py tests/test_vikingdb_knowledge_backend.py