fix(build): keep Windows release builds clean so ov reports the release version - #5588
Merged
Merged
Conversation
…y clean On Windows runners core.autocrlf=true checks the generated route tree out with CRLF; the Studio build rewrites it with LF, the tree turns dirty, and setuptools_scm resolves the bundled ov version as the next dev release. Also fail the build when the wheel and bundled ov versions differ. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ZaynJarvis
force-pushed
the
fix/windows-cli-version
branch
from
October 3, 2026 10:27
76c070f to
e3fecdc
Compare
t0saki
approved these changes
Oct 3, 2026
t0saki
left a comment
Collaborator
There was a problem hiding this comment.
LGTM per zhengxiao.wu; all builds incl. Windows green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows wheel of v0.4.23 ships an
ov.exethat reports0.4.24.dev0, while the wheel itself and the Linux/macOSovreport0.4.23. Same commit (df32bf6e), wrong version string.Root cause. Windows runners set
core.autocrlf=true, so checkout writesweb-studio/src/routeTree.gen.tswith CRLF.uv syncbuilds the Studio, and the TanStack Router plugin regenerates that tracked file with LF. Git now sees the tree as dirty, even thoughgit diffafter normalization is empty. When the CLI version is resolved at an exact release tag, setuptools_scm'sgit describe --dirtytherefore produces the next dev version. Later the job runsgit reset --hardbefore building the wheel, so the wheel is still0.4.23.Changes
.gitattributes:web-studio/src/routeTree.gen.ts text eol=lf, so checkout and the generator agree on every OS._build.yml: afteruv build --wheel, fail if the wheel version differs from the version compiled intoov(Linux and macOS/Windows jobs).Verification (Windows
workflow_dispatchruns of_build.yml)git status --porcelainprintedM web-studio/src/routeTree.gen.tsat the version-resolution step;git config core.autocrlf=true;git diffwas empty, with the warning "LF will be replaced by CRLF". Run: https://github.com/volcengine/OpenViking/actions/runs/37114001071git status --porcelainis empty at the same step. Run: https://github.com/volcengine/OpenViking/actions/runs/37114961801v0.4.23, a dirty tracked file turns the resolved version from0.4.23into0.4.24.dev0, which reproduces the release symptom.