Skip to content

Reject duplicate release-set root constraints - #117

Merged
voku merged 3 commits into
masterfrom
fix/release-set-duplicate-constraints
Aug 17, 2026
Merged

Reject duplicate release-set root constraints#117
voku merged 3 commits into
masterfrom
fix/release-set-duplicate-constraints

Conversation

@voku

@voku voku commented Aug 17, 2026

Copy link
Copy Markdown
Owner

What changed

  • reject packages declared in both root require and require-dev before combining the sections
  • add a focused regression test that runs the real standalone verifier with conflicting voku/agent-loop constraints

Why

CodeRabbit correctly found after #116 merged that PHP array union ($require + $requireDev) can hide a conflicting duplicate declaration from the right-hand section. That weakens the single-root-authority guarantee.

This follow-up fails deterministically on any duplicate package across the two root sections, before release-set ownership checks continue.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@voku, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 46 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bb150c5e-378e-40d1-bfb2-c89fe614941b

📥 Commits

Reviewing files that changed from the base of the PR and between 038b07c and 0843fd6.

📒 Files selected for processing (2)
  • tests/AgentLoopReleaseSetVerifierTest.php
  • tools/agent-loop/verify-release-set.php

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

voku commented Aug 17, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@voku
voku marked this pull request as ready for review August 17, 2026 06:15
@voku
voku merged commit bc1f714 into master Aug 17, 2026
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant