Increase regression coverage for Json mapper, collection helpers, and array-shape property contracts

[Copilot]

• Rebuild the current PHPUnit and PHPStan baseline after the previous inline-ignore cleanup
• Remove PHP >= 8 dead branches and impossible false-checks in core source files
• Fix a small adjacent batch of core-source PHPStan issues that become straightforward after that cleanup
• Run targeted PHPUnit and PHPStan for the touched files
• Re-run full PHPUnit and final review/security validation

---

This change is 

[voku]

/gemini review

[coveralls]

coverage: 92.372% (+3.1%) from 89.25% — copilot/refactor-property-type-checking into master

[gemini-code-assist]

Code Review

This pull request introduces support for PHP docblock array-shape annotations as an alternative to legacy @property tags for defining model properties and their types. It includes updates to the Arrayy core to parse these shapes from @template and @extends tags, support for optional keys in shapes, and a restriction against mixing both annotation styles in the same docblock. Additionally, the PR includes extensive new test coverage for the JSON mapper and core type-checking logic. Feedback focuses on a potential runtime error in TypeCheckPhpDoc when using reflection on dynamic properties, the scope of the mixed-annotation enforcement, and the strictness of the class-name filtering when parsing shapes from @extends tags.

[gemini-code-assist]

The use of ReflectionProperty on a dynamic property of stdClass will throw a ReflectionException in PHP 8.0+. Since $property is already a string representing the property name, and stdClass does not have declared properties, this reflection logic is both unnecessary and prone to runtime errors. You should use the property name directly.

        $tmpReflection = new self($property);

[gemini-code-assist]

The restriction against mixing @property tags and array-shape annotations is only enforced within a single DocBlock. If a parent class uses @property and a child class uses an array-shape, both will be processed without throwing a TypeError. If the intention is to forbid mixing across the entire inheritance hierarchy for a model, this check should be moved or expanded to account for inherited definitions.

[gemini-code-assist]

The check for self::class and ArrayyStrict::class inside getArrayShapeItemsFromDocBlock might be too restrictive if users create intermediate base classes that don't directly extend Arrayy or ArrayyStrict but are intended to carry shape metadata. Consider if allowing any class that eventually extends Arrayy would be more flexible, or if this strictness is a deliberate design choice to avoid parsing unrelated generic annotations.

[voku]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces support for PHPdoc array-shape annotations, providing an alternative to legacy @property tags for defining model properties. The implementation includes updates to the Arrayy class to parse these annotations from @template and @extends blocks, support for optional properties in constructor validation, and enhanced type-checking logic for nullable and array-shape pseudo-types. Comprehensive tests and documentation updates were also included to support these changes. I have no feedback to provide.

[voku]

@copilot if we need to ignore phpstan errors use the new way of phpstan v2 where we can ignore single identifiers inline in the code instead of regex in the config or hide full lines of code

[Copilot]

@copilot if we need to ignore phpstan errors use the new way of phpstan v2 where we can ignore single identifiers inline in the code instead of regex in the config or hide full lines of code

Updated the remaining PR-touched legacy inline PHPStan ignores to identifier-based PHPStan v2 ignores, and removed a couple that were no longer needed. Commit: 71d30ad

[sonarqubecloud]

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE