Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #635
Description
void secret sync --platform cloudflarewrote the bare name→value map tocf workers secrets bulk, so Cloudflare recorded a secret-change version but stored nothing. Wrap the map as{"secrets": {...}}to match the Workers secrets-bulk API.When the overwrite confirm is cancelled or declined (including non-TTY / CI), exit non-zero instead of 0. Add
--yesto skip that confirm for CI. Apply the same cancel/decline exit behavior to interactivesecret put.Happy to rename
--yesif maintainers prefer another flag name.Test
pnpm --filter void exec vitest run src/cli/cloudflare-operation-process.test.ts(includes bulk wrap + Worker 10007 draft-deploy failure path)