fix(cache): stop remote cache requests on Ctrl-C and fast-fail - #771
Merged
Merged
Conversation
Remote cache lookups, downloads, and uploads now stop as soon as the run is cancelled, instead of holding `vp run` open until they finish or time out. A task whose lookup was cut short doesn't start or restore outputs. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
wan9chi
force-pushed
the
fix-remote-cache-cancellation
branch
from
September 27, 2026 16:53
ff718b3 to
524bc21
Compare
fspy benchmarklinuxmacoswindows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Remote cache requests ignored cancellation. After Ctrl-C or a failing task,
vp runstill waited for in-flight lookups, downloads, and uploads to finish or hit the 60s read timeout, and a task whose lookup finished after cancellation could still start.Changes
run_child) cancels it too, while Ctrl-C still leaves running processes alone..tmpfile before removing it.cancelledas the reason..tmpfile is removed); e2e cases for Ctrl-C and fast-fail during a fetch, using a newvtt stalled-remote-cachehelper that serves an endpoint that never responds. Neither needs Node, so they run on all platforms.docs/cancellation.mdand the remote caching changelog entry.Closes #766