Conversation
The task cache migration skipped `run.tasks` in configs such as
`defineConfig((env) => ({ ... }) as UserConfig)` without a warning. It
looked through `as` directly around the config object, but not through
the parentheses of an arrow body or around the callback itself. The
project then failed to load its task graph after a successful migration.
Look through any mix of parentheses and type assertions around the
config object and its `defineConfig` callback.
Warn about tasks in a top-level `vite.config.*` object that is not the
exported config, such as a variable the config refers to or an object
passed to `mergeConfig`, instead of skipping them silently.
Contributor
|
✅ Staging deployment successful! Preview: https://viteplus-staging.void.app/ |
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-migrate-task-cache-wrapped-config-viteplus-dev.voidzero-docs.workers.dev (commit 3d19707)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
Contributor
CLI artifact sizes (
|
| Artifact | Format | Base | PR | Change |
|---|---|---|---|---|
packages/cli/dist |
Directory total | 2.35 MiB | 2.35 MiB | 0 B (0.00%) |
packages/core/dist |
Directory total | 3.96 MiB | 3.96 MiB | 0 B (0.00%) |
| Combined package dist | Directory total | 6.31 MiB | 6.31 MiB | 0 B (0.00%) |
vp (Linux x64) |
Binary | 11.29 MiB | 11.29 MiB | 0 B (0.00%) |
vp (Linux x64) |
gzip -9 | 4.88 MiB | 4.88 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | Binary | 32.24 MiB | 32.25 MiB | +4.00 KiB (+0.01%) |
| NAPI (Linux x64) | gzip -9 | 12.78 MiB | 12.78 MiB | +394 B (+0.00%) |
vp (macOS ARM64) |
Binary | 8.41 MiB | 8.41 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
gzip -9 | 4.26 MiB | 4.26 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | Binary | 39.85 MiB | 39.85 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | gzip -9 | 17.09 MiB | 17.09 MiB | +773 B (+0.00%) |
vp (Windows x64) |
Binary | 9.15 MiB | 9.15 MiB | 0 B (0.00%) |
vp (Windows x64) |
gzip -9 | 4.00 MiB | 4.00 MiB | +4 B (+0.00%) |
| NAPI (Windows x64) | Binary | 27.19 MiB | 27.19 MiB | +1.50 KiB (+0.01%) |
| NAPI (Windows x64) | gzip -9 | 10.89 MiB | 10.89 MiB | +633 B (+0.01%) |
| Trampoline (Windows x64) | Binary | 13.50 KiB | 13.50 KiB | 0 B (0.00%) |
| Trampoline (Windows x64) | gzip -9 | 7.08 KiB | 7.09 KiB | +3 B (+0.04%) |
| Installer (Windows x64) | Binary | 4.56 MiB | 4.56 MiB | 0 B (0.00%) |
| Installer (Windows x64) | gzip -9 | 2.13 MiB | 2.13 MiB | 0 B (0.00%) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The task cache migration from #2814 skipped
run.tasksin configs written as adefineConfigcallback with a type assertion, and printed no warning:It looked through
asdirectly around the config object, but not through the parentheses of the arrow body, nor through parentheses or assertions around the callback itself (defineConfig(((conf) => ({ ... })) as T)).vp migratereported success, thenvp runfailed withFailed to load task graph: Cache settings ... must be set under cacheand asked the user to runvp migrateagain.The migration now looks through any mix of parentheses and type assertions around the config object and around its
defineConfigcallback.It also warns about tasks in a top-level
vite.config.*object that is not the exported config, such as a variable the config refers to or an object passed tomergeConfig, instead of skipping them silently. Tasks created in other modules, for example by a shared helper, are still not detected; the migration rules page now says so.Found by the v1.0.0-rc.1 ecosystem smoke test (#2818):
vite-plus-ecosystem-ci/BlockNotevite.config.tsfiles left unchanged without a warning; CI fails to load the task graphvite-plus-ecosystem-ci/cloudflare-ostyped-storage'sbuildtask, which is passed to a helper. Tasks built in shared helper modules still need manual changesThe new unit tests fail against the previous logic and pass with this change.