Conversation
fengmk2
added this pull request to stack #2733
September 17, 2026 09:07
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://ci-homebrew-install-e2e-viteplus-dev.voidzero-docs.workers.dev (commit cdc2219)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homebrew installations need end-to-end coverage for the code under review. Add a macOS ARM64 job that runs when a pull request has the
test: install-e2elabel. Later pushes rerun it while the label remains.The job adapts the current official formula to build the tested commit and its pinned upstream resources. It checks first-run setup, bundled commands without npm access, saved preferences, diagnostics, and removal. Two formula revisions exercise
brew upgradeandbrew cleanup, including existing Bash command caches and saved shim paths.The bundled formatter check exposes a separate formula issue:
--no-optionalremoves Oxfmt's required native binding. The Homebrew formula needs a packaging fix for this check to pass.Failures retain the generated formulae, source revisions, command output, and Homebrew build logs as artifacts.
To run the checks locally, use a disposable Mac with Homebrew and Node.js: