ci: temporarily skip SFW tests on Windows - #2730
Merged
Merged
Conversation
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://fix-sfw-node-version-viteplus-dev.voidzero-docs.workers.dev (commit 8935021)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
Brooooooklyn
approved these changes
Sep 17, 2026
fengmk2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SFW
1.15.2embeds Node.js24.9.0and fails on Windows withUV_HANDLE_CLOSINGafter its child exits. Temporarily skip the Windows entry in the SFW test matrix. The TODO links nodejs/node#61999, which SFW must include before we enable Windows again.The Linux and macOS jobs use Node.js
24.21.0forvpcommands. The job downloads this runtime before SFW starts and prints its version through SFW.VP_NODE_VERSIONoverrides project pins but cannot change SFW's embedded runtime.CI also prints SFW's embedded Node.js version and executable path through a temporary
NODE_OPTIONSpreload script.