Skip to content

fix(cli): honor NO_COLOR in Rust output - #2716

Merged
fengmk2 merged 6 commits into
voidzero-dev:mainfrom
liangmiQwQ:liang/codex/honor-no-color
Sep 16, 2026
Merged

fengmk2 merged 6 commits into
voidzero-dev:mainfrom
liangmiQwQ:liang/codex/honor-no-color

Conversation

@liangmiQwQ

Copy link
Copy Markdown
Collaborator

Vite+ currently colors Rust diagnostics and status messages unconditionally. vp check also forces colors in captured lint output whenever stdout is a terminal, even when NO_COLOR is set.

This PR switches Rust CLI styling to console, reusing the color detection already used by the installer and Rust prompts. Diagnostic styling checks stderr. Captured lint output follows the parent's color support and preserves an explicit FORCE_COLOR value.

🤖 Generated with Codex

@liangmiQwQ

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-15T22:25:31.377570Z 5ac640f Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 5ac640ff16

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@socket-security

socket-security Bot commented Sep 16, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedcargo/​rustls@​0.23.44 ⏵ 0.23.458110093100100

View full report

@liangmiQwQ
liangmiQwQ marked this pull request as ready for review September 16, 2026 14:26
@liangmiQwQ
liangmiQwQ requested a review from fengmk2 September 16, 2026 14:26
@fengmk2 fengmk2 self-assigned this Sep 16, 2026
@fengmk2
fengmk2 merged commit ae2fe51 into voidzero-dev:main Sep 16, 2026
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants