Skip to content

fix(pm): reject filtered add and remove on Yarn Classic - #2705

Merged
fengmk2 merged 2 commits into
voidzero-dev:mainfrom
jong-kyung:fix/yarn-classic-filtered-dependencies
Sep 15, 2026
Merged

fengmk2 merged 2 commits into
voidzero-dev:mainfrom
jong-kyung:fix/yarn-classic-filtered-dependencies

Conversation

@jong-kyung

Copy link
Copy Markdown
Collaborator

Summary

Yarn Classic currently receives yarn workspaces foreach for filtered add/remove commands, but it does not support foreach and fails with Invalid subcommand.

Reject --filter with a clear error on Yarn Classic while preserving the existing Yarn Berry behavior. This also covers vp install <packages> --filter and Classic remove calls combining --filter with --recursive.

Reference

@jong-kyung jong-kyung self-assigned this Sep 15, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-15T03:42:28.203821Z 480b1e7 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jong-kyung
jong-kyung requested a review from fengmk2 September 15, 2026 00:09
@fengmk2

fengmk2 commented Sep 15, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 480b1e7626

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@fengmk2
fengmk2 merged commit 8c1f989 into voidzero-dev:main Sep 15, 2026
70 checks passed
@jong-kyung
jong-kyung deleted the fix/yarn-classic-filtered-dependencies branch September 15, 2026 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants