fix(create): remove nested monorepo lint config - #2667
Conversation
|
Can you add a new snapshot test case to cover this bug fix? |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
dd80e94 to
e988fd6
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd80e94f48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The standalone library template enables lint type checking, but nested lint configuration is not supported in monorepos. Remove the generated library's lint block during monorepo scaffolding while preserving it for standalone libraries. Apply the cleanup when adding libraries to existing monorepos as well. Use an AST-based config-key transform restricted to direct config objects, and add CLI snapshot coverage for both creation paths.
e988fd6 to
9932a48
Compare
|
@fengmk2 I added snapshot test coverage for this bug fix. Thanks for the suggestion! |
fengmk2
added
test: e2e
|
@semimikoh According to the description at #2668, the lint and fmt configurations do not support nested configurations, so we need to further process the |
2 participants
Summary
vite:libraryprojectsFixes #2640
Test plan
cargo test -p vp_migration remove_config_keycargo fmt --check -- crates/vp_migration/src/vite_config.rs crates/vp_migration/src/lib.rs packages/cli/binding/src/migration.rsgit diff --check