Conversation
naokihaba
marked this pull request as ready for review
September 18, 2026 02:23
Collaborator
Author
|
@codex review |
Collaborator
Author
|
#165 (comment) |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Centralizes Windows platform detection through a shared isWindows helper while preserving explicit platform testability.
Changes:
- Adds and tests the shared helper.
- Replaces duplicated Windows checks across source and tests.
- Regenerates GitLab and Azure bundles.
File summaries
| File | Description |
|---|---|
src/utils.ts |
Uses shared helper for home-directory selection. |
src/run-install.ts |
Uses helper for Windows warm-up logic. |
src/install-sfw.ts |
Uses helper for SFW behavior. |
src/ci/vp-dirs.ts |
Uses helper for installer selection. |
src/ci/vp-dirs.test.ts |
Updates platform-based skips. |
src/ci/run-install.ts |
Uses helper for retry behavior. |
src/ci/process.ts |
Uses helper for command lookup. |
src/ci/process.test.ts |
Updates Windows-only test detection. |
src/ci/platform.ts |
Adds shared Windows detection helper. |
src/ci/platform.test.ts |
Tests platform detection. |
src/ci/install-viteplus.ts |
Uses helper for paths and shell fallback. |
src/ci/install-sfw.ts |
Uses helper for SFW assets and paths. |
src/ci/install-script-urls.ts |
Uses helper for script selection. |
src/ci/cache-snapshot.test.ts |
Updates Windows link handling. |
dist/gitlab/index.mjs |
Regenerated GitLab bundle. |
dist/azure/index.mjs |
Regenerated Azure bundle. |
Review details
- Files reviewed: 14/17 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
@codex review |
fengmk2
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves: #157
Context
Windows platform checks, such as
process.platform === "win32", were duplicated across multiplemodules. This PR extracts them into a shared
isWindowshelper.Functions that accept an explicit platform value continue to pass it to the helper to keep
platform-dependent behavior easy to test.