Skip to content

test(compiler): cover @Inject(TOKEN) on pipe constructor params#235

Merged
Brooooooklyn merged 1 commit intomainfrom
test/pipe-inject-token-regression
Apr 16, 2026
Merged

test(compiler): cover @Inject(TOKEN) on pipe constructor params#235
Brooooooklyn merged 1 commit intomainfrom
test/pipe-inject-token-regression

Conversation

@Brooooooklyn
Copy link
Copy Markdown
Member

@Brooooooklyn Brooooooklyn commented Apr 16, 2026

Regression tests for b2dd390: assert the pipe factory injects the
@Inject token (not the erased type annotation), preserves Optional/
SkipSelf flags alongside @Inject, and still falls back to the type
annotation when @Inject is absent.

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com


Note

Low Risk
Test-only changes that add coverage for DI token/flag generation in pipe factories; no production logic is modified.

Overview
Adds new integration regression tests for pipe compilation to ensure constructor DI token extraction prefers @Inject(TOKEN) over the TypeScript type annotation, preventing erased interface types from becoming undefined at runtime.

The tests also assert @Optional/@SkipSelf flags are preserved when combined with @Inject, and that the factory still falls back to class type annotations when @Inject is not present.

Reviewed by Cursor Bugbot for commit dadfaa2. Bugbot is set up for automated code reviews on this repo. Configure here.

Regression tests for b2dd390: assert the pipe factory injects the
@Inject token (not the erased type annotation), preserves Optional/
SkipSelf flags alongside @Inject, and still falls back to the type
annotation when @Inject is absent.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Brooooooklyn Brooooooklyn merged commit 60277ce into main Apr 16, 2026
9 checks passed
@Brooooooklyn Brooooooklyn deleted the test/pipe-inject-token-regression branch April 16, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant