test(compiler): cover @Inject(TOKEN) on pipe constructor params#235
Merged
Brooooooklyn merged 1 commit intomainfrom Apr 16, 2026
Merged
test(compiler): cover @Inject(TOKEN) on pipe constructor params#235Brooooooklyn merged 1 commit intomainfrom
Brooooooklyn merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Regression tests for b2dd390: assert the pipe factory injects the
@Inject token (not the erased type annotation), preserves Optional/
SkipSelf flags alongside @Inject, and still falls back to the type
annotation when @Inject is absent.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com
Note
Low Risk
Test-only changes that add coverage for DI token/flag generation in pipe factories; no production logic is modified.
Overview
Adds new integration regression tests for pipe compilation to ensure constructor DI token extraction prefers
@Inject(TOKEN)over the TypeScript type annotation, preventing erased interface types from becoming undefined at runtime.The tests also assert
@Optional/@SkipSelfflags are preserved when combined with@Inject, and that the factory still falls back to class type annotations when@Injectis not present.Reviewed by Cursor Bugbot for commit dadfaa2. Bugbot is set up for automated code reviews on this repo. Configure here.