New package: rivalcfg-4.17.0

[uggwar]

• I tested the changes in this PR: YES
• This new package conforms to the package requirements: YES
• I built this PR locally for my native architecture, (x86_64-glibc)

[slymattz]

Are you sure it's licensed under Apache-2.0 and not WTFPL? Their github page says it's the latter, in which case, you should probably write WTFPL and do vlicense LICENSE in post_install()

grep -R WTFPL srcpkgs 
srcpkgs/tree-sitter-gitcommit/template:license="WTFPL"
srcpkgs/LGOGDownloader/template:license="WTFPL"
srcpkgs/WindowMaker-devel/template:license="GPL-2.0-or-later, WTFPL"
srcpkgs/WindowMaker-devel/template:     vlicense COPYING.WTFPL
srcpkgs/WindowMaker/template:license="GPL-2.0-or-later, WTFPL"
srcpkgs/WindowMaker/template:   vlicense COPYING.WTFPL
srcpkgs/fcount/template:license="WTFPL"
srcpkgs/gettext-stub-devel/template:license="WTFPL"
srcpkgs/gettext-stub/template:license="WTFPL"
srcpkgs/gohufont/template:license="WTFPL"
srcpkgs/hxtools/template:license="WTFPL AND LGPL-2.0-or-later AND GPL-2.0-or-later"
srcpkgs/hydrus/template:license="WTFPL"
srcpkgs/libcaca-devel/template:license="WTFPL"
srcpkgs/libcaca/template:license="WTFPL"
srcpkgs/lolcat-c/template:license="WTFPL"
srcpkgs/orjail/template:license="WTFPL"
srcpkgs/skroll/template:license="WTFPL"
srcpkgs/toilet/template:license="WTFPL"
srcpkgs/wifish/template:license="WTFPL"
srcpkgs/xcmenu/template:license="WTFPL"
srcpkgs/zimg-devel/template:license="WTFPL"
srcpkgs/zimg/template:license="WTFPL"
srcpkgs/zzuf/template:license="WTFPL"

[uggwar]

Auch, you are correct. Missed that one! Thanks, will fix tonight!

[ahesford]

We don't vendor content like those udev rules, especially when they can be automatically generated by the program.

[ahesford]

What are these tests? https://github.com/flozz/rivalcfg/tree/master/test

[uggwar]

I used another project as a template and this slipped through. Will remove and test!

[ahesford]

Fetching from $PYPI_SITE should be preferred, unless the GitHub tarball offers content (like tests) that are not shipped in the PyPI distribution.

[uggwar]

Thanks, didn't know. Will change this and see how it goes.

[uggwar]

I really hate that hard coded path for the udev rules that it checks every time it runs. I removed the patch that changes this path, since it probably is better to just go with the application defaults. What do you think?

[uggwar]

Any interest in this or maybe just close it?

[ahesford]

https://github.com/void-linux/void-packages/actions/runs/29483127221/job/87571238105?pr=60987#step:7:41

Tests aren't being run because you haven't provided checkdepends. You need at least pytest, and probably all of the run-time dependencies.

Prior comments addressed

[uggwar]

Seems like they use nox, of which I have never heard of before, to run their tests. It is also not packaged yet, but something I could add to this branch maybe? https://github.com/wntrblm/nox

[ahesford]

Don't use nox to run their tests. The tests are built around pytest, and we already have machinery to run tests with pytest. Just provide the dependencies and see how things run.

[slymattz]

@uggwar try this (GH contains tests in this case while PyPi doesn't).

just pass the -Q flag to run tests locally ./xbps-src -Q pkg rivalcfg

# Template file for 'rivalcfg'
pkgname=rivalcfg
version=4.17.0
revision=1
build_style=python3-pep517
make_check_args="--deselect=test/test_usbhid.py::TestOpenDevice::test_a_not_plugged_device"
hostmakedepends="python3-flit_core"
depends="python3-hidapi"
checkdepends="${depends} python3-pytest python3-pytest-flake8 python3-pytest-black"
short_desc="Steelseries gaming mice configurator"
maintainer="Christer Stenbrenden <christer@uggwar.net>"
license="WTFPL"
homepage="https://rivalcfg.flozz.org/"
distfiles="https://github.com/flozz/rivalcfg/archive/refs/tags/v${version}.tar.gz"
checksum=9ef0512b097ce46b77d0c74eb9c84411250c91a4dea1c77469a41bfacbe8705d

post_install() {
	# otherwise, running rivalcfg --update-udev as root would be necessary
	python3 -m rivalcfg --print-udev > 99-steelseries-rival.rules
	vinstall 99-steelseries-rival.rules 0644 usr/lib/udev/rules.d

	vlicense LICENSE
}

Other changes I made:

• deselect one test (couldn't get it to pass)
• runtime depends: I don't think python3-pyudev is needed. If you experienced problems w/out this package, let me know
• homepage: they do have a legitimate web page :) either way, GH page would be preferred over PyPi "homepage" link

I tested the package on my Rival 3 mouse:

$ rivalcfg -s 800
W: udev rules are not installed. You may not be able to open the device using a regular user.
   Run 'rivalcfg --update-udev' as root to fix.

There is a warning, but udev rules get applied as expected and switching from 400dpi to 800dpi or 1600dpi takes effect. # rivalcfg --update-udev would generate a file under /etc/udev/rules.d/99-steelseries-rival.rules anyway, so there should be no conflict.

[ahesford]

@slymattz please don't post templates in the comments. It makes review and comparison difficult. Instead, use the suggestion mechanism if you want to highlight meaningful changes.

[uggwar]

Thanks, @slymattz ! @ahesford explained to me that voidlinux doesn't vendor udev rules like that, so I removed them from the package. I will try out the test fixes you suggests.

[slymattz]

@uggwar oh yeah, I missed this bit about udev rules and the general policy not to vendor things like this.

@ahesford sure, I'll use the suggestion mechanism from now on. Thanks for your remark.