New package: payload-dumper-go-1.3.0

[r0man1an]

Testing the changes

• I tested the changes in this PR: YES

New package

• This new package conforms to the package requirements: YES

Local build testing

• I built this PR locally for my native architecture, x86_64-glibc

[r0man1an]

Did not expect that. I will have a look into it

[Duncaen]

I doubt that this is the correct solution.
Looked more like zstd dependency was missing.

[Duncaen]

Looks like the used gozstd go module is pretty bad and ships binaries in the repo that are linked into the program. This is why it won't work with musl.

[Duncaen]

This package works around it by dynamically linking system libzstd:

void-packages/srcpkgs/victoria-metrics/template

Lines 32 to 36 in caadef8

	# dynamically link system zstd
	vsed -i 's/#cgo LDFLAGS:.*/#cgo LDFLAGS: -lzstd/' \
	vendor/github.com/valyala/gozstd/libzstd_*.go
	cp vendor/github.com/valyala/gozstd/libzstd_linux_amd64.go \
	vendor/github.com/valyala/gozstd/libzstd.go

[r0man1an]

Got it, makes sense. I'll apply the same fix from victoria-metrics to link against system libzstd and update the template. Thanks for the help, have a nice evening.

[r0man1an]

I tested locally on x86_64 successfully.
The x86_64-musl build fails here due to a broken cross-x86_64-linux-musl toolchain in my local xbps-src env, so I couldn’t validate musl locally.
The change itself is limited to linking against system zstd as suggested

[Duncaen]

Instead of cross compiling for x86_64-musl, use ./xbps-src -A x86_64-musl pkg payload-dumper-go.

[r0man1an]

Thank you! I will review all failing points and hopefully fix them.

[Duncaen]

do_prepare is not a functions that exists. This should be pre_build or something like that.

But I think you also need to run go mod vendor so that the file actually exists for patching.

[r0man1an]

All issues on musl that I could test were resolved

[Duncaen]

wrksrc is the default directory.

[r0man1an]

Okay only one build failed and Lint is an easy fix.

[Duncaen]

makedepends should be above short_desc, you can use xnew from xtools to create a template with the right order the next time: https://github.com/leahneukirchen/xtools/blob/55cdf10841c128c2ad36a345a37f186b93824d4a/xnew#L42-L63

[Duncaen]

xtools also has xlint so you can run that locally.

[r0man1an]

Really appreciate you taking the time to walk me through all of this and being so patient, even when I didn’t get it right the first few times. I’m still new to Void packaging, so it genuinely helped a lot to have it explained properly. Thanks again.

[r0man1an]

xlint is happy now!