Skip to content

Fix task runner tools not appearing in Tools toggle menu - #169

Merged
darcyclarke merged 1 commit into
mainfrom
jules/fix-task-runner-tools-toggle
Sep 3, 2026
Merged

Fix task runner tools not appearing in Tools toggle menu#169
darcyclarke merged 1 commit into
mainfrom
jules/fix-task-runner-tools-toggle

Conversation

@vltbaudbot

@vltbaudbot vltbaudbot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Problem

On the benchmarks page at benchmarks.vlt.sh/#/task-runners/average, the Tools filter menu only shows package manager tools — it doesn't include the 3 task-runner-specific tools (nx, turbo, vp). These tools appear in the charts but users cannot toggle them on/off via the Tools dropdown.

Root Cause

In app/src/components/header.tsx, the HeaderNavigation component computes variationData using chartData.chartData.data[currentVariation] unconditionally. However, when on the task-runners route with the "average" variation, the actual data comes from chartData.taskRunnerAverageData (not chartData.chartData.data["average"]). Similarly for registries, the data comes from chartData.registryAverageData.

The VariationPage component already handles this correctly with route-aware conditionals, but the header was missing this logic.

Fix

Made the variationData computation in HeaderNavigation route-aware:

  • When baseRoute === "task-runners" and variation is "average", use chartData.taskRunnerAverageData
  • When baseRoute === "registries" and variation is "average", use chartData.registryAverageData
  • Otherwise, use chartData.chartData.data[currentVariation] (existing behavior)

This matches the logic already used in VariationPage (app/src/components/variation/index.tsx).

Fixes vltpkg/vlt.io#1942

Summary by CodeRabbit

  • Bug Fixes
    • Header navigation now displays task runner and registry data correctly for average variations.
    • Other variations continue to use their standard data.

The HeaderNavigation component always used chartData.chartData.data[variation]
to derive the available package managers for the Tools filter. However, for the
task-runners route with the 'average' variation, the actual data comes from
chartData.taskRunnerAverageData, and for registries it comes from
chartData.registryAverageData.

Make variationData route-aware so it uses the correct data source, matching
the logic already used in VariationPage.

Fixes vltpkg/vlt.io#1942

Co-authored-by: Jules Pichette <julespichette@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 67a632b0-060c-4edf-8676-18d2464438c1

📥 Commits

Reviewing files that changed from the base of the PR and between e2e5ecb and 63701fc.

📒 Files selected for processing (1)
  • app/src/components/header.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

Header navigation now detects average variations and selects route-specific aggregate data for task runner and registry routes.

Changes

Average variation routing

Layer / File(s) Summary
Header navigation data selection
app/src/components/header.tsx
The header imports isAverageVariation. Average variations use taskRunnerAverageData or registryAverageData by route. Other variations use the standard variation data.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 63701

The header now selects the appropriate aggregate data for average task-runner and registry views, restoring the expected Tools filter options. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the primary change: fixing missing task runner tools in the Tools toggle menu. It is concise and directly matches the pull request objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jules/fix-task-runner-tools-toggle

Comment @coderabbitai help to get the list of available commands.

@darcyclarke
darcyclarke merged commit 2a654d4 into main Sep 3, 2026
11 checks passed
@darcyclarke
darcyclarke deleted the jules/fix-task-runner-tools-toggle branch September 3, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants