fix(history-chart): show gaps for missing data instead of connecting lines - #150
Merged
Merged
Conversation
…lines
Set connectNulls={false} on the history chart Line components so that
days without results for a particular package manager or registry show
as visible gaps rather than smooth interpolated lines to the next real
data point.
evert
enabled auto-merge (squash)
August 19, 2026 20:41
vltbaudbot
force-pushed
the
evert/history-chart-gaps
branch
from
August 19, 2026 20:52
566097b to
349110f
Compare
darcyclarke
approved these changes
Aug 26, 2026
There was a problem hiding this comment.
Pull request overview
Updates the performance-over-time history chart to render visible gaps when a package manager/registry has missing benchmark data, rather than interpolating a continuous line through missing points.
Changes:
- Set
connectNulls={false}on Recharts<Line>series so missing values break the line. - Minor formatting/line-wrapping changes to imports and a few expressions for readability.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
connectNulls={false}on the Recharts<Line>components in the performance-over-time history chart. Days where a particular package manager or registry has no benchmark results now show as a visible gap in the line, instead of a smooth interpolation to the next real data point.Requested by Evert.