Repository navigation
fix: print why the Python frontend failed - #61
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
py2v file.pyprinted nothing and exited 1 when the Python frontend failed, for example on a file with a syntax error or a path that doesn't exist. The frontend does print a message, butos.exec_optreturns an error when the command exits non-zero, andmainhandled that withor { exit(1) }, so the block right below it that prints the output was never reached.Now the error is printed:
and a syntax error prints
SyntaxError in 'bad.py': invalid syntax (bad.py, line 1)the same way.--packagealready reported a syntax error in a file it translates.Fixes #5. That issue is only a title, "Add error handling", and this silent exit is what I found missing when I went through py2v's failure paths for it.
Test plan
tests/run_tests.vsh, a file with a syntax error and a file that doesn't exist: both fail with master's py2v and pass with this change.v tests/run_tests.vsh: 174 passed, 0 failed (172 before, plus the two checks).