Skip to content

fix(v4): fix api/advanced/reporters.md error eslint's format - #1006

Merged
NoiseFan merged 1 commit into
vitest-dev:v4from
NoiseFan:fix/patch-reporters
Jul 21, 2026
Merged

fix(v4): fix api/advanced/reporters.md error eslint's format#1006
NoiseFan merged 1 commit into
vitest-dev:v4from
NoiseFan:fix/patch-reporters

Conversation

@NoiseFan

Copy link
Copy Markdown
Collaborator

在提交PR之前,请确保你执行以下操作:

  • 曾阅读过翻译须知
  • 检查是否已经有PR以同样的方式解决问题,以避免创建重复。
  • 在此PR中描述正在解决的问题,或引用它解决的问题(例如:fixes #123)。

描述

附加上下文

@NoiseFan
NoiseFan merged commit a25f0b1 into vitest-dev:v4 Jul 21, 2026
1 check passed
@NoiseFan
NoiseFan deleted the fix/patch-reporters branch July 21, 2026 12:22

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2acbf60776

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread eslint.config.js
'advanced/api/import-example.md',
'api/advanced/import-example.md',
'guide/examples/*.md',
'reporters-life-cycle.md',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use an ignore glob that reaches the partial

In this flat ESLint setup, a bare reporters-life-cycle.md pattern only matches a file at the config root, while the newly added partial is api/advanced/reporters-life-cycle.md. As a result, CI/pre-commit runs such as eslint . or lint-staged on that staged file will still lint/format the partial, which defeats the purpose of moving the fragile lifecycle list out of reporters.md; use the actual relative path or **/reporters-life-cycle.md instead.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant