fix(core): use virtual module instead of fs URL for client injection#388
Open
webfansplz wants to merge 1 commit into
Open
fix(core): use virtual module instead of fs URL for client injection#388webfansplz wants to merge 1 commit into
webfansplz wants to merge 1 commit into
Conversation
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #386 by changing how the DevTools client injector is added to served HTML, aiming to avoid @fs-based URLs that break in Vite 8.1+ bundled (full-bundle) dev mode.
Changes:
- Replaces
<script type="module" src="/@fs/...">HTML injection with an inline module script that imports a new virtual module (virtual:vite-devtools-injection). - Adds
resolveId/loadhooks to serve the injected virtual module, which then imports the actual client injector entry.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #386