docs(risk-register): C-45/C-46 + C-19 re-scope#84
Merged
Conversation
…ase-docs audit) - C-45 (Tier 4): unfao/frames.py is an unused views-frames conformance adapter on no live path — forward-looking scaffolding for the C-40 migration; maintenance/ confusion surface (hardcodes S=1). Cross-ref C-40, #45. - C-46 (Tier 4): tests/test_datafactory_deploy_readiness.py is hardcoded to a local datafactory path → skipped in CI, and currently failing on the one machine that runs it (its strict-xfail flipped when datafactory advanced to 1.5.0-dev). Test hygiene, no correctness impact. Cross-ref C-36, C-44. - C-19 re-scoped: the unfao.py ADR-008 residual is resolved (#13); the live residual moved to enrichment.py (:42,:50,:103) + extraction.py:39 (raises without log-before). Trigger + Location rewritten; stays Tier 3. Header 44/24/20 -> 46/26/20. Register-only; ruff clean, suite green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register-only update folding in three findings from this session's
repo-assimilation+review-base-docsaudits:unfao/frames.pyis an unused views-frames conformance adapter on no live path (C-40 scaffolding; hardcodes S=1). xref C-40, FAO delivery path is point/DataFrame-based — won't carry rusty_bucket's pooled draws #45.tests/test_datafactory_deploy_readiness.pyis hardcoded to a local path → CI-skipped, currently failing locally (strict-xfail flipped at datafactory 1.5.0-dev). Test hygiene. xref C-36, C-44.unfao.pyADR-008 residual resolved (ADR-008 compliance: add log-before-raise to remaining raises (C-19) #13); live residual moved toenrichment.py:42,50,103+extraction.py:39. Trigger + Location rewritten; stays Tier 3.Header 44/24/20 → 46/26/20; entry counts reconcile. Register-only; ruff clean, 128 passed.