fix(manager): log-before-raise on the 3 remaining unfao.py raises (#13)#68
Merged
Merged
Conversation
… C-19) ADR-008 requires structural failures to be logged persistently AND raised. Three manager raises still raised without a preceding logger.error: the missing-ensemble and missing-loa guards in _read_forecast_data, and the datasets-None guard in _save. Apply the same construct-msg -> logger.error -> raise pattern the _validate gates already use. Also updates the UNFAOPostProcessorManager CIC §3 to match (drops the "partially compliant / 3 raises lacking" qualifier added in #66; #13 resolved). ruff clean; 126 passed (the unrelated CI-skipped datafactory stub deselected). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This was referenced Jun 27, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13 (C-19, ADR-008). The three
unfao.pyraises that still raised without a precedinglogger.errornow follow the same construct-msg →logger.error→ raise pattern as_validate:ensembleguard (_read_forecast_data)loaguard (_read_forecast_data)_save)(The 20 mapping.py raises this issue originally cited are moot — mapping.py was deleted in C-39.)
Also syncs the manager CIC §3 (drops the "partially compliant / 3 raises lacking" qualifier added in #66, now that #13 is resolved).
ruff clean; full suite passes (the one local failure,
test_datafactory_deploy_readiness, is an unrelated CI-skipped stub).Closes #13
🤖 Generated with Claude Code