fix: guard HLS load target and PiP null video - #1859
Open
Steve0x2a wants to merge 1 commit into
Open
Conversation
Snapshot the HLS loader target before the provider dynamic import so an unmount cannot construct HLSProvider with null. Require a real video element in canUsePictureInPicture, matching vidstack#989. Fixes vidstack#1771 Signed-off-by: Yi Zhan <stevesough@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
Fixes #1771. Thanks @rbao for the report and for identifying both sites.
Description:
Unmounting
<MediaPlayer>while the HLS provider chunk is still dynamically importing can constructHLSProviderwith a nulledloader.target.canUsePictureInPicture(null)then returnstruebecause!video?.disablePictureInPictureis true whenvideois null, soVideoPictureInPictureis created on null andEventsController.addthrowsTypeError: Cannot read properties of null (reading 'addEventListener').This is the same predicate class as #989 (
canUseVideoPresentation); that fix did not cover picture-in-picture.HLSProviderLoader.loadnow snapshotsconst target = this.targetbeforeawait import('./provider')and constructs with that element, or bails if it is null.canUsePictureInPicturerequires a real video element.Ready?
Yes.
Anything Else?
Unit tests in jsdom cover both sites (preferred over Slow 4G E2E). Scope is #1771 only.
Review Process:
pnpm -F vidstack exec vitest --run src/utils/support.test.ts src/providers/hls/loader.test.tscanUsePictureInPicture(null)is false whendocument.pictureInPictureEnabledis trueloader.targetduring the HLS provider import no longer throws