Fix #500: Selected Tags Lost After Rotation - #525
Open
victorwon2001 wants to merge 1 commit into
Open
victorwon2001 wants to merge 1 commit into
victorwon2001 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #500
Implementation summary
Moved the temporary selection state and options list in "showSelectBottomSheet" outside the modal builder's rebuild scope so that unsaved selections are no longer reset when the device rotates. Selection indices are managed as a copy, ensuring the caller's state is not modified before Save, while an explicit reload continues to resynchronize both the options and selection state as before. Added a regression test verifying that after Select All followed by a portrait→landscape rotation, all items remain selected and Save passes "[0, 1, 2]".
Changes
lib/common/logic/show_select.dart | 8 +--
test/common/widgets/fields/select_field_test.dart | 72 +++++++++++++++++++++++
2 files changed, 76 insertions(+), 4 deletions(-)
Testing