Repository navigation
test: kill a stray Apollo against real processes (#124) - #132
Merged
Merged
Conversation
The stray-Apollo kill only had unit tests for the command-line matching rule. This runs the whole path against real processes and real WMI: two fake sunshine.exe processes on two seats' configs, one kill call, and a check that only the process on the named config dies and no real sunshine.exe is touched. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stray-Apollo kill from #124 only had unit tests for the command-line matching rule. This adds a test that runs the whole path against real processes and real WMI.
It starts two fake
sunshine.exeprocesses, one on each of two seats' configs, and callsKillStrayApollosForConfig. It checks that the process on the named config is killed, the one on the other config survives, and any realsunshine.exeon the machine is not touched.Controls: WMI is shown to see each process under its own config only, and a config nobody runs kills nothing. With the kill method replaced by a no-op, the test fails (
Expected: 1, Actual: 0).Full suite: 1704 passed, 18 skipped, 0 failed. No source changes.
🤖 Generated with Claude Code