Repository navigation
fix(installer): name steam.exe, not the hook DLL, in the close-Steam command - #127
Merged
Merged
Conversation
…command (#126) Get-ProcessesUsingFolder records the module that matched in Path, which for steam.exe is MultiSeat.SteamHook.dll. The close-Steam command took that Path and printed the DLL after --steam. Every process entry now also carries ImagePath, the process's own exe (from MainModule, falling back to Win32_Process.ExecutablePath, else null). Format-SteamInUseMessage uses the first 'steam' entry whose ImagePath ends in steam.exe, and keeps the <path to steam.exe> placeholder otherwise. Path is unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #126
When an isolated Steam blocks an upgrade, the installer prints a command to close it.
That command passed MultiSeat.SteamHook.dll after --steam.
The launcher wants the path to steam.exe there, so it printed its usage text and did nothing.
The cause was the Path field on the process list.
For a process found by a loaded module, Path holds the module that matched, not the program.
steam.exe loads the hook DLL, so its Path was the DLL.
The message builder used that Path.
Each process entry now also has an ImagePath field with the process's own exe.
It is read from the process, with a Win32_Process fallback, and is null when neither works.
The message uses the first steam entry whose ImagePath ends in steam.exe.
If there is none, it keeps the placeholder.
Path is unchanged, so nothing else that reads it is affected.
Tested:
Not tested: I did not re-run this against a live isolated Steam. The tests use a stand-in steam.exe. The 32-bit steam.exe fallback path was not exercised.
The two-minute delay before Steam exited, noted in the issue, is a separate question and is not changed here.
🤖 Generated with Claude Code