Feature/carousel new block#359
Open
reunefe wants to merge 9 commits into
Open
Conversation
# Conflicts: # ui/src/react-admin/modules/maintenance-alerts/views/MaintenanceAlertsEditForm.tsx # ui/src/react-admin/modules/translations/views/TranslationsOverview.tsx # ui/src/shared/helpers/admin-core-config.tsx
bertyhell
reviewed
Jul 17, 2026
| editorProps: { | ||
| options: GET_FULL_HEADING_TYPE_OPTIONS(), | ||
| }, | ||
| validator: (value: string) => validateRequiredValue(value, 'titletype is verplicht'), |
Contributor
There was a problem hiding this comment.
shouldn't this also be a translation?
bertyhell
reviewed
Jul 17, 2026
| image: { | ||
| label: tText('Item image'), | ||
| editorType: ContentBlockEditor.FileUpload, | ||
| validator: (value: string) => validateRequiredValue(value, 'Afbeelding is verplicht'), |
bertyhell
reviewed
Jul 17, 2026
| }, | ||
| ], | ||
| }, | ||
| validator: (value: string) => validateRequiredValue(value, 'Weergave is verplicht'), |
bertyhell
reviewed
Jul 17, 2026
| &-nav { | ||
| display: flex; | ||
| align-items: center; | ||
| gap: .8rem; |
Contributor
There was a problem hiding this comment.
variables.$g-spacer-unit
bertyhell
reviewed
Jul 17, 2026
Comment on lines
+119
to
+136
| width: 28rem !important; | ||
|
|
||
| .c-block-overview-with-carousel__slide-image { | ||
| min-height: 28rem; | ||
| } | ||
|
|
||
| .c-block-overview-with-carousel__slide-description { | ||
| flex: unset; | ||
| } | ||
| } | ||
|
|
||
| &__round { | ||
| width: 28rem !important; | ||
| border-radius: 140px 140px 0 0; | ||
|
|
||
| .c-block-overview-with-carousel__slide-image { | ||
| height: 28rem; | ||
| clip-path: circle(); |
bertyhell
reviewed
Jul 17, 2026
Comment on lines
+118
to
+130
| icon={<Icon name="arrowLeft" />} | ||
| title={tText('Vorige slide')} | ||
| ariaLabel={tText('Vorige slide')} | ||
| onClick={() => controlledSwiper?.slidePrev()} | ||
| /> | ||
| )} | ||
| {showNextSlideButton && ( | ||
| <Button | ||
| variants={['black', 'sm']} | ||
| icon={<Icon name="arrowRight" />} | ||
| title={tText('Volgende slide')} | ||
| ariaLabel={tText('Volgende slide')} | ||
| onClick={() => controlledSwiper?.slideNext()} |
Contributor
There was a problem hiding this comment.
these translations are HET_ARCHIEF only? since the blok is hetarchief only
bertyhell
reviewed
Jul 17, 2026
|
|
||
| if (!value && emptyFieldValidatorMessage) { | ||
| errorArray.push(emptyFieldValidatorMessage); | ||
| } |
Contributor
There was a problem hiding this comment.
shouldn't we have an else with a default message if !value && !emptyFieldValidatorMessage?
or otherwise emptyFieldValidatorMessage should always be a string
bertyhell
approved these changes
Jul 17, 2026
…types fix(ARC-3790): fix typescript types
bertyhell
force-pushed
the
feature/Carousel_new-block
branch
from
July 20, 2026 14:13
94534b0 to
e66c5c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.