fix: propagate search failures and normalize Node.js package architecture - #28
Merged
Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js search returned a successful empty list on network errors and non-200 HTTP responses, allowing vfox to cache the failure. Raise an actionable error instead, so the core skips cache writes and subsequent searches can recover.
Normalize Go's
386architecture to Node'sx86package suffix, retaining the existingamd64→x64mapping and native ARM64 selection. Report missing runtime architecture or an archive absent from SHASUMS256.txt before attempting a nonexistent download. The Windows issue does not include its actual runtime architecture, so this fixes the confirmed missing mapping without forcing all Windows hosts to x64.Validation:
Fixes #16
Fixes #23