Skip to content

fix: propagate search failures and normalize Node.js package architecture - #28

Merged
aooohan merged 1 commit into
mainfrom
codex/fix-node-downloads-16-23
Sep 12, 2026
Merged

aooohan merged 1 commit into
mainfrom
codex/fix-node-downloads-16-23

Conversation

@aooohan

@aooohan aooohan commented Sep 12, 2026

Copy link
Copy Markdown
Member

Node.js search returned a successful empty list on network errors and non-200 HTTP responses, allowing vfox to cache the failure. Raise an actionable error instead, so the core skips cache writes and subsequent searches can recover.

Normalize Go's 386 architecture to Node's x86 package suffix, retaining the existing amd64x64 mapping and native ARM64 selection. Report missing runtime architecture or an archive absent from SHASUMS256.txt before attempting a nonexistent download. The Windows issue does not include its actual runtime architecture, so this fixes the confirmed missing mapping without forcing all Windows hosts to x64.

Validation:

  • Reproduced failures before fixing; nine offline hook cases pass, now included in CI.
  • Actual vfox SDK cache integration: HTTP 503 creates no cache, a fresh SDK retries successfully, and another fresh SDK reuses the successful cache.
  • Windows x64/x86/ARM64 package names resolve against official Node 20.16.0 checksums. No Windows installation was performed.
  • Plugin package validation and actionlint pass.

Fixes #16
Fixes #23

@aooohan aooohan mentioned this pull request Sep 12, 2026
@aooohan
aooohan merged commit 308bb7d into main Sep 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

win无法安装nodejs包 It is wrong to save empty available versions as cache when connection failed

1 participant