Fix: calculate overall ETA from exact progress instead of rounded value#22
Fix: calculate overall ETA from exact progress instead of rounded value#22insign wants to merge 1 commit into
Conversation
Calculates ETA from unrounded overall progress and checks for true completion of all individual tasks, preventing the ETA from returning `0` prematurely when the average rounded value reaches `100`. This also provides an optimization by removing a secondary cache lookup. Co-authored-by: insign <1113045+insign@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixes a bug where
getOverallEstimatedTimeRemainingprematurely returned0when the exact overall progress was close enough to100to be rounded up bygetOverallProgress().This change manually computes the unrounded overall progress for the ETA calculation, ensuring accurate estimations. It also checks that all local processes are strictly
>= 100to consider the group complete.Additionally, this change acts as a performance optimization and avoids potential race conditions because
getOverallProgressDatais only called once. Tests forisCompleteandgetOverallEstimatedTimeRemainingrounding bugs have been added.PR created automatically by Jules for task 12618220089286673229 started by @insign