Skip to content

TS: Transactions #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmillan merged 2 commits into from
Oct 20, 2026
Merged

TS: Transactions #988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0179416
TS: Transactions
jmillan Oct 20, 2026
43980d9
More types
jmillan Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions src/Dialog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,12 +266,10 @@ module.exports = class Dialog {

const stateChanged = () => {
if (
request.server_transaction.state === Transactions.Status.ACCEPTED ||
request.server_transaction.state ===
Transactions.C.STATUS_ACCEPTED ||
request.server_transaction.state ===
Transactions.C.STATUS_COMPLETED ||
request.server_transaction.state ===
Transactions.C.STATUS_TERMINATED
Transactions.Status.COMPLETED ||
request.server_transaction.state === Transactions.Status.TERMINATED
) {
request.server_transaction.removeListener(
'stateChanged',
Expand All @@ -288,7 +286,7 @@ module.exports = class Dialog {
if (request.hasHeader('contact')) {
request.server_transaction.on('stateChanged', () => {
if (
request.server_transaction.state === Transactions.C.STATUS_ACCEPTED
request.server_transaction.state === Transactions.Status.ACCEPTED
) {
this._remote_target = request.parseHeader('contact').uri;
}
Expand All @@ -299,7 +297,7 @@ module.exports = class Dialog {
if (request.hasHeader('contact')) {
request.server_transaction.on('stateChanged', () => {
if (
request.server_transaction.state === Transactions.C.STATUS_COMPLETED
request.server_transaction.state === Transactions.Status.COMPLETED
) {
this._remote_target = request.parseHeader('contact').uri;
}
Expand Down
9 changes: 4 additions & 5 deletions src/Dialog/RequestSender.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,19 +59,18 @@ module.exports = class DialogRequestSender {
if (
(this._request.method === JsSIP_C.INVITE ||
(this._request.method === JsSIP_C.UPDATE && this._request.body)) &&
request_sender.clientTransaction.state !==
Transactions.C.STATUS_TERMINATED
request_sender.clientTransaction.state !== Transactions.Status.TERMINATED
) {
this._dialog.uac_pending_reply = true;

const stateChanged = () => {
if (
request_sender.clientTransaction.state ===
Transactions.C.STATUS_ACCEPTED ||
Transactions.Status.ACCEPTED ||
request_sender.clientTransaction.state ===
Transactions.C.STATUS_COMPLETED ||
Transactions.Status.COMPLETED ||
request_sender.clientTransaction.state ===
Transactions.C.STATUS_TERMINATED
Transactions.Status.TERMINATED
) {
request_sender.clientTransaction.removeListener(
'stateChanged',
Expand Down
4 changes: 2 additions & 2 deletions src/RTCSession.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,7 +843,7 @@ module.exports = class RTCSession extends EventEmitter {
this._status === C.STATUS_WAITING_FOR_ACK &&
this._direction === 'incoming' &&
this._request.server_transaction.state !==
Transactions.C.STATUS_TERMINATED
Transactions.Status.TERMINATED
) {
// Save the dialog for later restoration.
const dialog = this._dialog;
Expand All @@ -863,7 +863,7 @@ module.exports = class RTCSession extends EventEmitter {
this._request.server_transaction.on('stateChanged', () => {
if (
this._request.server_transaction.state ===
Transactions.C.STATUS_TERMINATED
Transactions.Status.TERMINATED
) {
this.sendRequest(JsSIP_C.BYE, {
extraHeaders,
Expand Down
Loading
Loading