Skip to content

fix(web-shared): snapshot generic iterables - #3889

Open
mitul-s wants to merge 1 commit into
c+ms/expandable-headers-a180from
c+ms/fix-iterable-snapshots-6966
Open

fix(web-shared): snapshot generic iterables#3889
mitul-s wants to merge 1 commit into
c+ms/expandable-headers-a180from
c+ms/fix-iterable-snapshots-6966

Conversation

@mitul-s

@mitul-s mitul-s commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Why

Live iterators can lose values when React renders or compares them more than once. Generic iteration can also block the inspector because it has no item limit.

Scope

The first commit adds browser-level regressions for repeated renders, replacement iterators, bounded consumption, truncation, and malformed entries() methods. The implementation will follow in a separate commit.

Blast Radius

The tests cover DataInspector in @workflow/web-shared. No runtime code changes in this revision.

Verification

The focused regression run follows this pre-test commit.

PR Checklist - Required to merge

  • 📦 pnpm changeset was run to create a changelog for this PR
  • 🔒 Commits include DCO sign-off
  • 📝 Ping @vercel/workflow in a comment once the PR is ready, and the above checklist is complete
Open in Web Open in Cursor 

Signed-off-by: Cursor Agent <cursoragent@cursor.com>

Co-authored-by: Mitul Shah <mitulxshah@gmail.com>
@mitul-s
mitul-s requested a review from a team as a code owner August 28, 2026 19:43
@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview, v0 Aug 28, 2026 7:47pm
example-nextjs-workflow-webpack Ready Ready Preview, v0 Aug 28, 2026 7:47pm
example-workflow Ready Ready Preview, v0 Aug 28, 2026 7:47pm
workbench-astro-workflow Ready Ready Preview, v0 Aug 28, 2026 7:47pm
workbench-express-workflow Ready Ready Preview, v0 Aug 28, 2026 7:47pm
workbench-fastify-workflow Building Building Preview, v0 Aug 28, 2026 7:47pm
workbench-hono-workflow Ready Ready Preview, v0 Aug 28, 2026 7:47pm
workbench-nestjs-workflow Ready Ready Preview, v0 Aug 28, 2026 7:47pm
workbench-nitro-workflow Ready Ready Preview, v0 Aug 28, 2026 7:47pm
workbench-nuxt-workflow Ready Ready Preview, v0 Aug 28, 2026 7:47pm
workbench-python-workflow Ready Ready Preview, v0 Aug 28, 2026 7:47pm
workbench-sveltekit-workflow Ready Ready Preview, v0 Aug 28, 2026 7:47pm
workbench-tanstack-start-workflow Ready Ready Preview, v0 Aug 28, 2026 7:47pm
workbench-vite-workflow Ready Ready Preview, v0 Aug 28, 2026 7:47pm
workflow-docs Ready Ready Preview, v0 Aug 28, 2026 7:47pm
workflow-swc-playground Ready Ready Preview, v0 Aug 28, 2026 7:47pm
workflow-tarballs Ready Ready Preview, v0 Aug 28, 2026 7:47pm
workflow-web Ready Ready Preview, v0 Aug 28, 2026 7:47pm

@changeset-bot

changeset-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 05cf507

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

Sim World

Simulated world deterministic testing for races. Traces

🟠 world-sim scenario book — 1 fail of 41 total

fence=per-spec

scenario outcome events virt replay violations
smoke-no-steps completed 3 0ms ok 0
smoke-one-step completed 6 0ms ok 0
hook-at-step-started completed 12 0ms ok 0
hook-at-step-completed completed 12 0ms ok 0
hook-at-hook-created completed 12 0ms ok 0
deadline-hook-wins completed 7 1.0h ok 0
deadline-expires completed 7 1.0h ok 0
long-sleep completed 11 30.0d ok 0
hook-never-arrives stalled 3 0ms skipped 0
step-retries-twice completed 10 2.0s ok 0
parallel-steps completed 9 0ms ok 0
hook-on-execution-state completed 12 0ms ok 0
peek-hook-before-branch completed 12 0ms ok 0
peek-hook-after-branch completed 12 0ms ok 0
peek-hook-at-registration completed 12 0ms ok 0
race-hook-before-probe completed 12 0ms ok 0
race-hook-after-probe completed 12 0ms ok 0
race-duplicate-delivery completed 13 0ms ok 0
attr-hook-before-step completed 11 0ms ok 0
attr-hook-after-step completed 11 0ms ok 0
attr-from-step-body completed 13 0ms ok 0
fork-hook-after-timeout completed 14 1.0m ok 0
fork-hook-before-timeout completed 14 1.0m ok 0
count-hook-after-timeout completed 17 1.0m ok 0
count-hook-before-timeout completed 20 1.0m ok 0
stale-read-step-count-fork completed 20 1.0m ok 0
stale-read-equal-step-counts completed 14 1.0m ok 0
step-vs-step-fork completed 12 0ms ok 0
step-vs-step-fork-fenced completed 12 0ms ok 0
fence-catches-benign-direction completed 12 5ms ok 0
in-flight-before-decision completed 17 1.0m ok 0
in-flight-before-decision-counted completed 17 1.0m ok 0
in-flight-after-decision completed 19 2.0m ok 0
stale-read-step-count-fork-fenced completed 20 1.0m ok 0
fork-hook-wins completed 13 1.0m ok 0
fork-timeout-wins completed 13 1.0m ok 0
unclaimed-payload-under-fork completed 17 1.0m ok 0
claimed-payload-under-fork completed 17 1.0m ok 0
writers-independent-step-bodies completed 12 0ms ok 0
writers-scripted-tempo completed 12 0ms ok 0
cancel-mid-step cancelled 7 0ms skipped 0

Full trace: world-sim.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants