fix(web-shared): snapshot generic iterables - #3889
Open
mitul-s wants to merge 1 commit into
Open
Conversation
Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Mitul Shah <mitulxshah@gmail.com>
Contributor
|
Contributor
Sim WorldSimulated world deterministic testing for races. Traces 🟠 world-sim scenario book — 1 fail of 41 total
Full trace: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Live iterators can lose values when React renders or compares them more than once. Generic iteration can also block the inspector because it has no item limit.
Scope
The first commit adds browser-level regressions for repeated renders, replacement iterators, bounded consumption, truncation, and malformed
entries()methods. The implementation will follow in a separate commit.Blast Radius
The tests cover
DataInspectorin@workflow/web-shared. No runtime code changes in this revision.Verification
The focused regression run follows this pre-test commit.
PR Checklist - Required to merge
pnpm changesetwas run to create a changelog for this PR@vercel/workflowin a comment once the PR is ready, and the above checklist is complete