Skip to content

fix(server): stop sending x-vercel-ip #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
feugy wants to merge 1 commit into from
Closed

fix(server): stop sending x-vercel-ip #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/web/src/server/experiments.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ describe('trackExposure', () => {
expect(body.props).toEqual({ valid: 'test' });
});

it('reuses provided referer, user-agent, cookie and IP headers', async () => {
it('reuses provided referer, user-agent and cookie headers', async () => {
const userAgent = 'custom-agent/2.0';
const cookie = 'session=def456';
const ip = '190.80.130.60';
Expand All @@ -325,7 +325,6 @@ describe('trackExposure', () => {
headers: {
'content-type': 'application/json',
'user-agent': userAgent,
'x-vercel-ip': ip,
cookie,
'x-va-server': '1',
},
Expand Down
10 changes: 3 additions & 7 deletions packages/web/src/server/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ describe('server track', () => {
);
});

it('reuses provided referer, user-agent, cookie and IP headers', async () => {
it('reuses provided referer, user-agent and cookie headers', async () => {
const userAgent = 'custom-agent/2.0';
const cookie = 'session=def456';
const ip = '190.80.130.60';
Expand All @@ -238,7 +238,6 @@ describe('server track', () => {
headers: {
'content-type': 'application/json',
'user-agent': userAgent,
'x-vercel-ip': ip,
cookie,
'x-va-server': '1',
},
Expand All @@ -255,7 +254,7 @@ describe('server track', () => {
);
});

it("reuses provided request's referer, user-agent, cookie and IP", async () => {
it("reuses provided request's referer, user-agent and cookie", async () => {
const userAgent = 'mobile-agent/2.0';
const cookie = 'session=def456';
const ip = '10.0.0.1';
Expand All @@ -281,7 +280,6 @@ describe('server track', () => {
headers: {
'content-type': 'application/json',
'user-agent': userAgent,
'x-vercel-ip': ip,
cookie,
'x-va-server': '1',
},
Expand All @@ -298,7 +296,7 @@ describe('server track', () => {
);
});

it('reuses provided referer, user-agent, cookie and IP options', async () => {
it('reuses provided referer, user-agent and cookie options', async () => {
const userAgent = 'custom-agent/1.0';
const cookie = 'session=abc123';
const ip = '196.82.138.67';
Expand All @@ -324,7 +322,6 @@ describe('server track', () => {
headers: {
'content-type': 'application/json',
'user-agent': userAgent,
'x-vercel-ip': ip,
cookie,
'x-va-server': '1',
},
Expand Down Expand Up @@ -597,7 +594,6 @@ describe('server track', () => {
headers: {
'content-type': 'application/json',
'user-agent': userAgent,
'x-vercel-ip': ip,
cookie,
'x-va-server': '1',
},
Expand Down
1 change: 0 additions & 1 deletion packages/web/src/server/request.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,6 @@ export async function dispatch({
headers: {
'content-type': 'application/json',
'user-agent': requestHeaders['user-agent'] as string,
'x-vercel-ip': requestHeaders['x-forwarded-for'] as string,
'x-va-server': '1',
cookie: requestHeaders.cookie as string,
...(BYPASS_SECRET
Expand Down
Loading