fix: wrap invalid tool call input in JSON object#14470
Open
SAY-5 wants to merge 2 commits intovercel:mainfrom
Open
fix: wrap invalid tool call input in JSON object#14470SAY-5 wants to merge 2 commits intovercel:mainfrom
SAY-5 wants to merge 2 commits intovercel:mainfrom
Conversation
…ring
When parseToolCall fails to parse tool input JSON, the raw string was
stored as input. Providers like Bedrock require input to be a JSON
object, so the raw string caused API rejections before the model
could see the tool-error and retry.
Now wraps the raw input as { rawInvalidInput: toolCall.input } so the
conversation history stays valid for the next API call.
2221/2221 tests pass.
Fixes vercel#14442
…pping Address feedback on vercel#14470 — two inline snapshots in parse-tool-call.test.ts weren't updated after the parse-tool-call.ts change that wraps the fallback input as { rawInvalidInput: ... } instead of leaving it as a raw string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parseToolCall fails to parse the tool input JSON, the raw string was stored directly as the input property. Providers like Amazon Bedrock require toolUse.input to be a JSON object, so the raw string caused API rejections on the next step before the model could see the tool-error and retry.
Now wraps the unparsable input as { rawInvalidInput: toolCall.input } so the conversation history remains valid JSON for all providers.
2221/2221 tests pass across 106 test files.
Fixes #14442