Fix signed zero in integer boundary inference - #622
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #619.
An equality guard such as
z === 0accepts both zero signs, but integer-boundary inference could proveMath.trunc(Math.min(1 / z, 1))safe even though-0produces-Infinity. Negative odd powers had the same problem.Account for both zero signs when dividing by the zero interval and when folding powers of zero. Preserve the NaN result of
0 / 0, acceptance of direct zero crossings, and proofs for safely clamped results. The existing interval domain combines both zero signs, so some safe one-sided clamps may now be conservatively refused even when the source only produces positive zero.Add analyzer regressions, source-level rejection checks for i64/u64 returns, and native differential cases for safe clamps evaluated with both
+0and-0.Validation: workspace build; all 164 library unit and integer-boundary integration tests in both plain and sanitized modes; complete plain and sanitized suite coverage in partitions. Initial package-permission, debugger-attachment, and sanitizer-configuration failures passed isolated rechecks. Sanitized Effect fixtures use the CI setting
ASAN_OPTIONS=detect_leaks=0.