Fix lost writes after ?? and || defaults - #616
Open
KayleeWilliams wants to merge 1 commit into
Open
KayleeWilliams wants to merge 1 commit into
KayleeWilliams wants to merge 1 commit into
Conversation
Contributor
|
@KayleeWilliams is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hit this moving our CLI (inthhq/inth) to 0.2.
parseArgumentspassesresultto a function that setsskillsArguments, and on 0.2 the caller never sees the write. Smaller repro:mayBeOptionaltreatsa ?? banda || bas optional if either side is, but both givebwhenais undefined. Soargs[0] ?? ""counted as optional,resultgot a widened shape, and the call tofillwent through a%rec.widthcopy. This checks only the right side for??and||.nullish-default-record-writes.tsfails on main and passes with this. The rest of the corpus passes too, except1640-fd-read-decode.tsand2283-structured-clone.cjs, which fail on main for me as well (Node 24.19). I didn't run the sanitized lane.The copy itself is still there. With
result.command = args[0]and no default, the write is still lost. I wasn't sure how you'd want that fixed, so I left it alone.