fix(macos): align mixed-face text baselines - #397
Open
ctate wants to merge 5 commits into
Open
Conversation
ctate
commented
Aug 22, 2026
ctate
commented
Collaborator
- Place AppKit text from each resolved font's baseline metrics.
- Preserve engine baselines in measured-line and wrapping fallback paths.
- Add a pixel regression using bundled Geist sans and mono faces.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Place AppKit text from each resolved font's baseline metrics. - Preserve engine baselines in measured-line and wrapping fallback paths. - Add a pixel regression using bundled Geist sans and mono faces.
ctate
force-pushed
the
ctate/text-runs-fix
branch
from
August 23, 2026 00:37
e550a26 to
417d482
Compare
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
There was a problem hiding this comment.
Additional Suggestion:
canvasFontMeasureInk produces vertical ink metrics with an inverted (y-DOWN) sign, opposite to the y-UP convention shared by the consumer and all other providers, so registered-font ink bounds are vertically flipped on the pure-Zig measurement path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.