Use isEquivalentTo instead of equals for tint and alternate in Separa…

[LonelyMidoriya]

…tion

Summary by CodeRabbit

• Bug Fixes
  • Improved consistency validation for separation colors by recognizing equivalent color definitions, reducing incorrect inconsistency reports.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5aa0bc51-78bf-4c85-a1b0-536090f40454

📥 Commits

Reviewing files that changed from the base of the PR and between ba21eb7 and b87221e.

📒 Files selected for processing (1)

• validation-model/src/main/java/org/verapdf/gf/model/impl/pd/colors/GFPDSeparation.java

🚧 Files skipped from review as they are similar to previous changes (1)

• validation-model/src/main/java/org/verapdf/gf/model/impl/pd/colors/GFPDSeparation.java

---

📝 Walkthrough

Walkthrough

The separation consistency check now uses equivalence rather than strict object equality when comparing alternate spaces and tint transforms for separations sharing a colorant name.

Changes

Separation consistency

Layer / File(s)	Summary
Use equivalence for consistency checks validation-model/src/main/java/org/verapdf/gf/model/impl/pd/colors/GFPDSeparation.java	getareTintAndAlternateConsistent() compares alternate spaces and tint transforms with isEquivalentTo(...) instead of equals(...).

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: maximplusov

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change from equals to isEquivalentTo for tint and alternate comparisons in Separation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch annex-j-comparison

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.